Branch: refs/heads/main Home: https://github.com/OpenAMP/open-amp Commit: 31fb9138bc2ba6c408936f3270341dbfd99bdb14 https://github.com/OpenAMP/open-amp/commit/31fb9138bc2ba6c408936f3270341dbfd... Author: Andrew Davis afd@ti.com Date: 2024-05-20 (Mon, 20 May 2024)

Changed paths: M lib/include/openamp/rpmsg_virtio.h

Log Message: ----------- rpmsg_virtio: Fix return value comment for rpmsg_virtio_get_role()

The `role` member of `struct virtio_device` stores either the value VIRTIO_DEV_DRIVER or VIRTIO_DEV_DEVICE. This means the function rpmsg_virtio_get_role() will also return one of these values. The values RPMSG_HOST and RPMSG_REMOTE are defined to be the same, but there is no need for this redefinition. Update the return values in the comment docs.

While here, remove the same from rpmsg_virtio_set_wait_cb() which does not return anything, this looks to be a copy/paste error.

Signed-off-by: Andrew Davis afd@ti.com

Commit: 5d8e63f2efe5337ca1f3a612dee9ac37e1b8d2a8 https://github.com/OpenAMP/open-amp/commit/5d8e63f2efe5337ca1f3a612dee9ac37e... Author: Andrew Davis afd@ti.com Date: 2024-05-20 (Mon, 20 May 2024)

Changed paths: M lib/rpmsg/rpmsg_virtio.c

Log Message: ----------- rpmsg_virtio: Deprecate RPMSG_HOST and RPMSG_REMOTE definitions

For all cases when the role is checked in rpmsg_virtio, what is being checked is the role of the underlying virtio layer. As such, we should be matching against the role definitions for the virtio layer (VIRTIO_DEV_DEVICE and VIRTIO_DEV_DRIVER). Fix this here.

While the underlying virtio layer may be asymmetric, the RPMSG layer generally is symmetrical. There is no need to define a HOST or REMOTE role specific to the RPMSG layer. And as there are now no more internal users of these definitions, deprecate them here.

Signed-off-by: Andrew Davis afd@ti.com

Commit: fdef576779d676732e26b26687940965785bc1ee https://github.com/OpenAMP/open-amp/commit/fdef576779d676732e26b266879409657... Author: Andrew Davis afd@ti.com Date: 2024-05-20 (Mon, 20 May 2024)

Changed paths: M lib/rpmsg/rpmsg_virtio.c

Log Message: ----------- rpmsg_virtio: Use VIRTIO_ROLE_IS_{DRIVER,DEVICE}() macros

Now that we match role to VIRTIO_DEV_{DRIVER,DEVICE} we can replace all these double check if statements with the role checking macro already used in all other files.

Signed-off-by: Andrew Davis afd@ti.com

Compare: https://github.com/OpenAMP/open-amp/compare/e03d09a3fb08...fdef576779d6

To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications