May 2024 - Openamp-rp - lists.openampproject.org

[OpenAMP/open-amp] 0538be: lib: fix build error using legacy VIRTIO_DEVICE/DR...

by Arnaud Pouliquen

Branch: refs/heads/v2024.05-rc Home: https://github.com/OpenAMP/open-amp Commit: 0538be5c9433d761e1479d554936d820476934e5 https://github.com/OpenAMP/open-amp/commit/0538be5c9433d761e1479d554936d820… Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M lib/include/openamp/virtio.h Log Message: ----------- lib: fix build error using legacy VIRTIO_DEVICE/DRIVER_ONLY As part of the deprecation process for VIRTIO_DEVICE_ONLY and VIRTIO_DRIVER_ONLY, we should still support builds without errors when possible. For legacy support, define VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT default values based on VIRTIO_DEVICE_ONLY and VIRTIO_DRIVER_ONLY. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications

7 months

1
0
0 0

[OpenAMP/open-amp] 0538be: lib: fix build error using legacy VIRTIO_DEVICE/DR...

by Arnaud Pouliquen

Branch: refs/heads/main Home: https://github.com/OpenAMP/open-amp Commit: 0538be5c9433d761e1479d554936d820476934e5 https://github.com/OpenAMP/open-amp/commit/0538be5c9433d761e1479d554936d820… Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M lib/include/openamp/virtio.h Log Message: ----------- lib: fix build error using legacy VIRTIO_DEVICE/DRIVER_ONLY As part of the deprecation process for VIRTIO_DEVICE_ONLY and VIRTIO_DRIVER_ONLY, we should still support builds without errors when possible. For legacy support, define VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT default values based on VIRTIO_DEVICE_ONLY and VIRTIO_DRIVER_ONLY. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications

7 months

1
0
0 0

[OpenAMP/libmetal]

by Arnaud Pouliquen

Branch: refs/heads/v2024.05-rc Home: https://github.com/OpenAMP/libmetal To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/libmetal/settings/notifications

7 months

1
0
0 0

[OpenAMP/open-amp]

by Arnaud Pouliquen

Branch: refs/heads/v2024.05-rc Home: https://github.com/OpenAMP/open-amp To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications

7 months

1
0
0 0

[OpenAMP/open-amp] 31fb91: rpmsg_virtio: Fix return value comment for rpmsg_v...

by Andrew Davis

Branch: refs/heads/main Home: https://github.com/OpenAMP/open-amp Commit: 31fb9138bc2ba6c408936f3270341dbfd99bdb14 https://github.com/OpenAMP/open-amp/commit/31fb9138bc2ba6c408936f3270341dbf… Author: Andrew Davis <afd(a)ti.com> Date: 2024-05-20 (Mon, 20 May 2024) Changed paths: M lib/include/openamp/rpmsg_virtio.h Log Message: ----------- rpmsg_virtio: Fix return value comment for rpmsg_virtio_get_role() The `role` member of `struct virtio_device` stores either the value VIRTIO_DEV_DRIVER or VIRTIO_DEV_DEVICE. This means the function rpmsg_virtio_get_role() will also return one of these values. The values RPMSG_HOST and RPMSG_REMOTE are defined to be the same, but there is no need for this redefinition. Update the return values in the comment docs. While here, remove the same from rpmsg_virtio_set_wait_cb() which does not return anything, this looks to be a copy/paste error. Signed-off-by: Andrew Davis <afd(a)ti.com> Commit: 5d8e63f2efe5337ca1f3a612dee9ac37e1b8d2a8 https://github.com/OpenAMP/open-amp/commit/5d8e63f2efe5337ca1f3a612dee9ac37… Author: Andrew Davis <afd(a)ti.com> Date: 2024-05-20 (Mon, 20 May 2024) Changed paths: M lib/rpmsg/rpmsg_virtio.c Log Message: ----------- rpmsg_virtio: Deprecate RPMSG_HOST and RPMSG_REMOTE definitions For all cases when the role is checked in rpmsg_virtio, what is being checked is the role of the underlying virtio layer. As such, we should be matching against the role definitions for the virtio layer (VIRTIO_DEV_DEVICE and VIRTIO_DEV_DRIVER). Fix this here. While the underlying virtio layer may be asymmetric, the RPMSG layer generally is symmetrical. There is no need to define a HOST or REMOTE role specific to the RPMSG layer. And as there are now no more internal users of these definitions, deprecate them here. Signed-off-by: Andrew Davis <afd(a)ti.com> Commit: fdef576779d676732e26b26687940965785bc1ee https://github.com/OpenAMP/open-amp/commit/fdef576779d676732e26b26687940965… Author: Andrew Davis <afd(a)ti.com> Date: 2024-05-20 (Mon, 20 May 2024) Changed paths: M lib/rpmsg/rpmsg_virtio.c Log Message: ----------- rpmsg_virtio: Use VIRTIO_ROLE_IS_{DRIVER,DEVICE}() macros Now that we match role to VIRTIO_DEV_{DRIVER,DEVICE} we can replace all these double check if statements with the role checking macro already used in all other files. Signed-off-by: Andrew Davis <afd(a)ti.com> Compare: https://github.com/OpenAMP/open-amp/compare/e03d09a3fb08...fdef576779d6 To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications

7 months

1
0
0 0

[OpenAMP/libmetal] 1de0f2: lib: fix doxygen warning in log.h

by Arnaud Pouliquen

Branch: refs/heads/main Home: https://github.com/OpenAMP/libmetal Commit: 1de0f27d7d5e76409a25a371d94cda3cd2c1c194 https://github.com/OpenAMP/libmetal/commit/1de0f27d7d5e76409a25a371d94cda3c… Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> Date: 2024-05-20 (Mon, 20 May 2024) Changed paths: M lib/log.h Log Message: ----------- lib: fix doxygen warning in log.h fix following warning: lib/log.h:91: warning: argument 'args...' of command @param is not found in the argumentlist of metal_log(level, fmt, args...) lib/log.h:98: warning: The following parameter of metal_log(level, fmt, args...) is not documented: parameter 'args...' Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/libmetal/settings/notifications

7 months

1
0
0 0

[OpenAMP/libmetal] d52e69: lib: Do not label function declarations in headers...

by Andrew Davis

Branch: refs/heads/main Home: https://github.com/OpenAMP/libmetal Commit: d52e69bb7995e2875c297c4f55e472870916988c https://github.com/OpenAMP/libmetal/commit/d52e69bb7995e2875c297c4f55e47287… Author: Andrew Davis <afd(a)ti.com> Date: 2024-05-20 (Mon, 20 May 2024) Changed paths: M lib/device.h M lib/log.h M lib/shmem.h M lib/sys.h M lib/system/freertos/cache.h M lib/system/generic/cache.h M lib/system/linux/sys.h M lib/version.h Log Message: ----------- lib: Do not label function declarations in headers with extern This is not needed for function declarations, they already have implicit external linkage. Signed-off-by: Andrew Davis <afd(a)ti.com> To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/libmetal/settings/notifications

7 months

1
0
0 0

[OpenAMP/open-amp] babba1: remoteproc: Assign ops and priv to rproc struct in...

by Andrew Davis

Branch: refs/heads/main Home: https://github.com/OpenAMP/open-amp Commit: babba1bca0cb446978fc7f8deb8c4b084ce9dbc3 https://github.com/OpenAMP/open-amp/commit/babba1bca0cb446978fc7f8deb8c4b08… Author: Andrew Davis <afd(a)ti.com> Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M lib/remoteproc/remoteproc.c Log Message: ----------- remoteproc: Assign ops and priv to rproc struct in init by default These need to be set in the rproc specific init() callback currently, instead set them before calling the callback to make doing that in the callback optional. They can still be overwritten if needed in the init() callback but if this is not needed as in some simple cases, then the callback is not needed. Like other functions here, make this optional if no additional modifications to the rproc struct are needed. Signed-off-by: Andrew Davis <afd(a)ti.com> Commit: e03d09a3fb0807ad5567f4845f68bbb798f7fd58 https://github.com/OpenAMP/open-amp/commit/e03d09a3fb0807ad5567f4845f68bbb7… Author: Andrew Davis <afd(a)ti.com> Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M apps/examples/load_fw/zynqmp_apu_lcm_rproc_example.c M apps/examples/load_fw/zynqmp_r5_lcm_rproc_example.c M apps/examples/load_fw/zynqmp_rpu_lcm_rproc_example.c M apps/machine/microblaze_generic/zynqmp_mb_a53_rproc.c M apps/machine/zynq7/zynq_a9_rproc.c M apps/machine/zynqmp/zynqmp_linux_r5_proc.c M apps/machine/zynqmp_r5/zynqmp_r5_a53_rproc.c M apps/system/linux/machine/generic/platform_info.c Log Message: ----------- apps: Remove manual assignment of ops and priv to rproc struct This is handled by default, remove instances from apps. In cases where there is nothing left in the init() callback remove it as it is now optional. Signed-off-by: Andrew Davis <afd(a)ti.com> Compare: https://github.com/OpenAMP/open-amp/compare/bf8722873052...e03d09a3fb08 To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications

7 months, 1 week

1
0
0 0

[OpenAMP/open-amp] 40820b: rpmsg_virtio: Move returned buffer kick to common ...

by Andrew Davis

Branch: refs/heads/main Home: https://github.com/OpenAMP/open-amp Commit: 40820be22369fb96c6ead4a7b17a506aa0d16745 https://github.com/OpenAMP/open-amp/commit/40820be22369fb96c6ead4a7b17a506a… Author: Andrew Davis <afd(a)ti.com> Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M lib/rpmsg/rpmsg_virtio.c Log Message: ----------- rpmsg_virtio: Move returned buffer kick to common location After returning a buffer we kick the other side. This is done after both call sites of the function that returns the buffer. Move this kick call into that function to reduce code duplication and prevent it from not being done after returning the buffer. Signed-off-by: Andrew Davis <afd(a)ti.com> Commit: bf8722873052c7e67b90e6a18e70859710ea070d https://github.com/OpenAMP/open-amp/commit/bf8722873052c7e67b90e6a18e708597… Author: Andrew Davis <afd(a)ti.com> Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M lib/rpmsg/rpmsg_virtio.c Log Message: ----------- rpmsg_virtio: Move get RX buffer into receive loop This allows us to only need to call rpmsg_virtio_get_rx_buffer() once at the start of the loop and is easier to comprehend. Signed-off-by: Andrew Davis <afd(a)ti.com> Compare: https://github.com/OpenAMP/open-amp/compare/7257deaab349...bf8722873052 To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications

7 months, 1 week

1
0
0 0

[OpenAMP/open-amp] 304c34: lib: fix doxygen miscellaneous warnings

by Arnaud Pouliquen

Branch: refs/heads/main Home: https://github.com/OpenAMP/open-amp Commit: 304c34606e5990364e0f9b983fd0cd6f476c4739 https://github.com/OpenAMP/open-amp/commit/304c34606e5990364e0f9b983fd0cd6f… Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M lib/include/openamp/remoteproc.h M lib/include/openamp/rpmsg_rpc_client_server.h M lib/include/openamp/virtio.h M lib/include/openamp/virtio_mmio.h M lib/rpmsg/rpmsg_internal.h M lib/rpmsg/rpmsg_virtio.c Log Message: ----------- lib: fix doxygen miscellaneous warnings Remove warning reported by Doxygen on doc generation: - rewrite enum documentation, - replace @ by \ref for references, - fix param names Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> Commit: 7257deaab3491543261dfc8b084f6f332f2ef57f https://github.com/OpenAMP/open-amp/commit/7257deaab3491543261dfc8b084f6f33… Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M lib/include/openamp/rpmsg.h M lib/include/openamp/virtio.h Log Message: ----------- lib: fix doxygen warning: "Found unknown command" The doxygen build report issue for function descriptions that provide reference to some function parameters using @: ... lib/include/openamp/rpmsg.h:160: warning: Found unknown command '\data' lib/include/openamp/rpmsg.h:160: warning: Found unknown command '\len' ... Fix the warning by replacing with back-ticks that will be interpreted as code by Markdown(Markdown support is enabled in the Doxygen configuration). Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> Compare: https://github.com/OpenAMP/open-amp/compare/2e5026fd7d46...7257deaab349 To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications

7 months, 1 week

1
0
0 0

2024

2023

2022

2021

2020

2019

Openamp-rp May 2024