Branch: refs/heads/main Home: https://github.com/OpenAMP/open-amp Commit: 17b2594ab6e7929bac7d876748bed0d16a657f1e https://github.com/OpenAMP/open-amp/commit/17b2594ab6e7929bac7d876748bed0d16... Author: Sergei Korneichuk sergei.korneichuk@amd.com Date: 2022-10-18 (Tue, 18 Oct 2022)
Changed paths: M apps/examples/rpc_demo/rpc_demod.c
Log Message: ----------- app: rpc_demod: fix buffer overflow in handle_read
Fix the following error: Remote>Opened file 'remote.file' with fd = 8 *** buffer overflow detected ***: rpc_demod-shared 1. Change RPC_BUFF_SIZE to accomodate the remote 2. Set size to the minimum of the request or the buffer size
Signed-off-by: Sergei Korneichuk sergei.korneichuk@amd.com
Commit: bb6d16837b2c0e8f5c6d2c18c220846c2df43607 https://github.com/OpenAMP/open-amp/commit/bb6d16837b2c0e8f5c6d2c18c220846c2... Author: Ben Levinsky ben.levinsky@xilinx.com Date: 2022-10-18 (Tue, 18 Oct 2022)
Changed paths: M apps/examples/load_fw/load_fw.c M apps/examples/load_fw/zynqmp_rpu_lcm_rproc_example.c
Log Message: ----------- apps: examples: load_fw: fix up for -werror
with werror flag compilation fails. update to build
Signed-off-by: Ben Levinsky ben.levinsky@xilinx.com
Commit: 29fbf24ef926d553e56092c9d4513a4752a7b0cb https://github.com/OpenAMP/open-amp/commit/29fbf24ef926d553e56092c9d4513a475... Author: Manikanta Sreeram manikanta.sreeram@xilinx.com Date: 2022-10-18 (Tue, 18 Oct 2022)
Changed paths: M apps/examples/load_fw/lscript.ld M apps/system/generic/machine/zynqmp_r5/linker_large_text.ld M apps/system/generic/machine/zynqmp_r5/linker_remote.ld
Log Message: ----------- apps: update linker scripts to SPDX license
Update linker scripts to SPDX based licensing.
Signed-off-by: Manikanta Sreeram manikanta.sreeram@xilinx.com
Commit: 2e9f3a31cc70dc04bd2c5fc45fb96602173003b2 https://github.com/OpenAMP/open-amp/commit/2e9f3a31cc70dc04bd2c5fc45fb966021... Author: Manikanta Sreeram manikanta.sreeram@xilinx.com Date: 2022-10-18 (Tue, 18 Oct 2022)
Changed paths: M LICENSE.md
Log Message: ----------- Update LICENSE.md to cover CI test scripts
Add Apache and GPL licensing to cover CI test scripts in case they are converted to SPDX: Apache-2.0 scripts/ci/check_compliance.py scripts/do_checkpatch.sh scripts/gitlint/commit_rules.py GPL-2.0 scripts/checkpatch.pl scripts/spelling.txt
Note: Neither Apache nor GPL are used by the libmetal library itself.
Signed-off-by: Manikanta Sreeram manikanta.sreeram@xilinx.com
Commit: 4ab1ce6f95a9046363d4b3d3f19075d373c03bb4 https://github.com/OpenAMP/open-amp/commit/4ab1ce6f95a9046363d4b3d3f19075d37... Author: Ben Levinsky ben.levinsky@xilinx.com Date: 2022-10-18 (Tue, 18 Oct 2022)
Changed paths: M apps/examples/rpc_demo/rpc_demod.c
Log Message: ----------- app: rpc_demod: replace copy_from_shbuf with metal_io_block_read
After a toolchain upgrade, the OpenAMP rpc_demod application would fail with a bus error on AArch64 Linux. This was because the call to copy_from_shbuf() was now inlined by the optimizer and the compiler generated code that used 8-byte copies ("ldp x10, x11 [x4, #16]" followed by the corresponding store instruction). The bus error happened when the address in x4 (the index) was 4-byte aligned, but not 8-byte aligned.
This would not be a problem with normal user-space memory, but the memory used for the shared buffer between the remote processor and Linux is mapped as device memory. On AArch64, device memory is strictly ordered and the alignment and width of accesses must match.
Replace copy_from_shbuf() with a call to metal_io_block_read(), which is intended to do this sort of thing, and also makes this a better example of how to use OpenAMP.
Return error only on a negative return value from copy_from_shbuf in rpmsg_endpoint_cb.
Signed-off-by: Ben Levinsky ben.levinsky@xilinx.com
Compare: https://github.com/OpenAMP/open-amp/compare/2b6a38a9c689...4ab1ce6f95a9