- Openamp-system-reference - lists.openampproject.org

[PATCH v3 0/6] Add Xilinx RPU subsystem support

by Tanmay Shah

This patch series adds bindings document for RPU subsystem found on Xilinx ZynqMP platforms. It also adds device nodes and driver to enable RPU subsytem in split mode and lockstep mode. Xilinx ZynqMP platform contains Remote Processing Unit(RPU). RPU subsystem contains two arm cortex r5f cores. RPU subsystem can be configured in split mode, locsktep mode and single-cpu mode. RPU subsystem also contains 4 Tightly Coupled Memory(TCM) banks. In lockstep mode, all 4 banks are combined and total of 256KB memory is made available to r5 core0. In split mode, both cores can access two TCM banks i.e. 128 KB. RPU can also fetch data and execute instructions from DDR memory along with TCM memory. --- Changes in v3: - Fix checkpatch script indentation warning - Remove unused variable from xilinx remoteproc driver - use C style comments, i.e /*...*/ - Remove redundant debug information which can be derived using /proc/device-tree - Fix multilined comment format - s/"final fot TCM"/"final for TCM" - Function devm_kzalloc() does not return an code on error, just NULL. Remove redundant error check for this function throughout the driver. - Fix RPU mode configuration and add documentation accordingly - Get rid of the indentations to match function documentation style with rest of the driver - Fix memory leak by only using r5_rproc->priv and not replace it with new instance - Use 'i' for the outer loop and 'j' for the inner one as per convention - Remove redundant error and NULL checks throughout the driver - Use devm_kcalloc() when more than one element is required - Add memory-regions carveouts during driver probe instead of parse_fw call This removes redundant copy of reserved_mem object in r5_core structure. - Fix memory leak by using of_node_put() - Fix indentation of tcm_mem_map function args - Remove redundant init of variables - Initialize tcm bank size variable for lockstep mode - Replace u32 with phys_addr_t for variable stroing memory bank address - Add documentation of TCM behavior in lockstep mode - Use dev_get_drvdata instead of platform driver API - Remove info level messages - Fix checkpatch.pl warnings - Add documentation for the Xilinx r5f platform to understand driver design Changes in v2: - Remove proprietary copyright footer from cover letter Ben Levinsky (3): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU configuration APIs Tanmay Shah (3): dt-bindings: remoteproc: Add Xilinx RPU subsystem bindings arm64: dts: xilinx: zynqmp: Add RPU subsystem device node drivers: remoteproc: Add Xilinx r5 remoteproc driver .../bindings/remoteproc/xlnx,r5f-rproc.yaml | 139 +++ arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 17 + drivers/firmware/xilinx/zynqmp.c | 96 ++ drivers/remoteproc/Kconfig | 12 + drivers/remoteproc/Makefile | 1 + drivers/remoteproc/xlnx_r5_remoteproc.c | 975 ++++++++++++++++++ include/dt-bindings/power/xlnx-zynqmp-power.h | 6 + include/linux/firmware/xlnx-zynqmp.h | 60 ++ 8 files changed, 1306 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/xlnx,r5f-rproc.yaml create mode 100644 drivers/remoteproc/xlnx_r5_remoteproc.c base-commit: c1fe10d238c0256a77dbc4bf6493b9782b2a218d -- 2.25.1

3 years, 9 months

1
6
0 0

Posted OpenAMP System Reference presentation from HPP call to website

by Nathalie Chan King Choy

Hi, I finally got around to one of my old action items. The PDF version of the presentation that Tomas & Bill gave to the HPP working group about OpenAMP System Reference is now posted to https://www.openampproject.org/docs/presentations/OpenAMPSystemReferencePro… Updates compared to what was actually presented to HPP: * Added mention of RTOS * Updated Wind River logo Best regards, Nathalie

3 years, 10 months

1
0
0 0

Organizing virtual sprint tasks

by Nathalie Chan King Choy

Hi all, Since Linaro Jira is not accessible to everyone in the System Reference project, do we want to use GitHub Projects in the OpenAMP System Refence repo to organize the tasks for next week's sprint? https://github.com/OpenAMP/openamp-system-reference/projects Columns could be: Backlog, To do today, In progress, Done? Or, do you prefer to keep the GitHub repo & issue queue limited to what is being published and not the draft work, similar to how we're having content in Google Drive until it's ready for publication outside this working group? If so, we could avoid making people sign up for new tools by staying basic & just have a Google spreadsheet to track the tasks. Other ideas are welcome. Thanks & regards, Nathalie

3 years, 10 months

1
0
0 0

Calling for agenda: 2022-01-19 OpenAMP System Reference call

by Nathalie Chan King Choy

Hi all, Agenda: Please let us know if you have additional topics. Here is what I collected so far for the agenda: * Individual updates. Objectives from 1/5 call: * Dan: Targeting to make what is in progress more shareable * Bill: Reproducible builds * Tanmay: Continue efforts to upstream Xilinx driver * What to work on prior to the Virtual Sprint in week of 1/31? Any sprint pre-work? For reference: Notes from last call: https://github.com/OpenAMP/openamp-system-reference/wiki/OpenAMP-System-Ref… Medium-term outlook: March/April demo goal * User-consumable instructions for Xilinx QEMU and ST HW * Automated build in VM with at least 1 test passing, from staging kernel & OpenAMP libraries main branch * Hypervisorless virtio demo on Xilinx QEMU with some OpenAMP attached + instructions/scripts to reproduce * Stretch: Outline of official OpenAMP documentation Thanks & regards, Nathalie

3 years, 10 months

1
0
0 0

2022-01-05 OpenAMP System Reference notes and action items

by Nathalie Chan King Choy

Hi all, The notes can be found at: https://github.com/OpenAMP/openamp-system-reference/wiki/OpenAMP-System-Ref… Action items: * @jeffrey.hancock@siemens.com<mailto:jeffrey.hancock@siemens.com>: Once Tammy joins, send Nathalie her email address. * @Nathalie Chan King Choy<mailto:nathalie@xilinx.com>: Add Tammy to relevant OpenAMP mailing lists & calendar invitation for this working group. * @Nathalie Chan King Choy<mailto:nathalie@xilinx.com>: Try setting up a Slack channel using Xilinx Slack w/ external ppl * @Nathalie Chan King Choy<mailto:nathalie@xilinx.com>: Set up the daily meetings for 1hr during week of Jan 31, 2022 * @Bill Mills<mailto:bill.mills@linaro.org>, @Milea, Danut Gabriel (Danut)<mailto:Danut.Milea@windriver.com>, @Tanmay Shah<mailto:tanmays@xilinx.com>, @Arnaud POULIQUEN<mailto:arnaud.pouliquen@st.com>: Block off 4h/day during week of Jan 31, 2022 * (DONE) Tanmay: Send instructions to download the ELF with the steps Thanks & regards, Nathalie

3 years, 10 months

1
0
0 0

Post pmu-rom.elf on xilinx.com public download area

by Tanmay Shah

Hi all, File pmu-rom.elf for ZynqMP QEMU is available for Public Download on Xilinx public domain. Following is link for the same: https://www.xilinx.com/bin/public/openDownload?filename=PMU_ROM.tar.gz On Bash Shell I used following commands to download and extract pmu-rom.elf: wget https://www.xilinx.com/bin/public/openDownload?filename=PMU_ROM.tar.gz -O PMU_ROM.tar.gz tar -xvzf PMU_ROM.tar.gz ls PMU_ROM/ I have attached snapshot of steps performed on my local machine that shows how to download and extract pmu-rom.elf. This compressed file PMU_ROM.tar.gz conatins pmu-rom.elf binary and PMU_ROM-LICENSE.txt files. The LICENSE file contains LICENSE of binary as suggested by legal team. Thanks and Happy New Year !!! Tanmay Shah tanmay.shah(a)xilinx.com

3 years, 10 months

1
0
0 0

Calling for agenda: 1/5/22 OpenAMP System Reference call

by Nathalie Chan King Choy

Happy New Year! Notes from last call: https://github.com/OpenAMP/openamp-system-reference/wiki/OpenAMP-System-Ref… Initial agenda: * What could be feasible for March/April demo? * Virtual sprint - checking month-by-month: Could sometime in January make sense? * Who is new Zephyr point of contact? * Individual updates. Objectives for 1/5 call were: * Dan: Targeting to make what is in progress more shareable * Bill: Reproducible builds * Arnaud: Document how to build using upstream SW * Tanmay/Nathalie: Get the PMU ROM ELF posted for wget * Tanmay: Continue efforts to upstream Xilinx driver * What to aim to complete prior to next call? Please let us know if you have additional agenda topics. Thanks & regards, Nathalie

3 years, 11 months

1
0
0 0

Calling for agenda: 12/8 OpenAMP System Reference call

by Nathalie Chan King Choy

Hi all, Notes from last call: https://github.com/OpenAMP/openamp-system-reference/wiki/OpenAMP-System-Ref… Initial agenda: * Individual updates * Should System Reference group write up a proposal for possible OpenAMP contracting $ for board to vote on? * What to work on for 12/31 milestone? * When to reconvene in new year? Please let us know if you have additional agenda topics. Thanks & regards, Nathalie

3 years, 11 months

1
0
0 0

Calling for agenda for 11/24/21 OpenAMP System Reference call

by Nathalie Chan King Choy

Hi all, Please let us know your agenda topic requests for this week's sync. * Tanmay: Update on upstreaming * Nathalie: PMU ROM & KV260 updates * Other individual updates * 12/1 or not 12/1? Is much progress expected by 12/1 call if US folks are the ones with tasks in flight & US Thanksgiving is end of this week? * Continue with weekly sync, or change to every 2 weeks? * Objectives to complete before next meeting? Reminder to please respond to the poll for which weeks would be best candidates for a virtual sprint in ~Q1CY22: https://doodle.com/poll/n4wb9698y8748c76?utm_source=poll&utm_medium=link And of action items from last week: * @Tomas Evensen<mailto:tomase@xilinx.com>: Add to slide 7: Want to showcase proprietary RTOSes * @Tomas Evensen<mailto:tomase@xilinx.com>: Send Nathalie the latest slides after update * Nathalie: Update to new WR logo in the slides * Nathalie: PDF-ize & post & share the sharing link * Nathalie: Post the PPT template and presentation & share the sharing link to members * Nathalie: Poll this group for what week might be best to have a virtual sprint in the new year. Thanks & regards, Nathalie

4 years

1
0
0 0

[Response requested] Scheduling a virtual sprint for OpenAMP System Reference in early 2022

by Nathalie Chan King Choy

Hi all, During this week's call, Arnaud suggested it could be helpful to have a virtual sprint sometime in the new year. The proposed duration is 1 week when participants could spend most of their time that week to work on this project & attend a daily sync up discussion. Please let us know what weeks are most likely feasible for you in this poll: https://doodle.com/poll/n4wb9698y8748c76?utm_source=poll&utm_medium=link Thanks & regards, Nathalie

4 years

1
0
0 0

2025

2024

2023

2022

2021

Openamp-system-reference